Skip to content

fix: Intall latest version 3.3.1 and fix braking changes#391

Merged
egalvis27 merged 3 commits into
mainfrom
fix/inxt-js-version
Jun 17, 2026
Merged

fix: Intall latest version 3.3.1 and fix braking changes#391
egalvis27 merged 3 commits into
mainfrom
fix/inxt-js-version

Conversation

@egalvis27

@egalvis27 egalvis27 commented Jun 15, 2026

Copy link
Copy Markdown

What is Changed / Added


  • Migrated the file upload and download integrations to the new SDK promise-based contract, removing the old completion callback flow.
  • Refactored temporal file uploads to use async/await, propagate abortSignal, keep the same progress/start/finish/error events, and ensure streams are closed on abort or failure.
  • Refactored storage file downloads to use the new direct promise flow, preserve progress and lifecycle events, and replace manual stop-state handling with AbortController.
  • Simplified the download factory by passing the Environment instance directly to the downloader instead of wrapping the SDK call in an additional adapter layer.
  • Refactored thumbnail uploads to use an abortable timeout, so timed out uploads are actively cancelled and timers are always cleaned up.
  • Refactored backup content uploads to call environment.upload directly, rely on the SDK for multipart handling, propagate abortSignal, and preserve stream cleanup and existing error mapping behavior.
  • Updated the related tests to match the new SDK behavior, including success, timeout, abort, empty contentsId, and failure scenarios.

Why

  • The SDK contract changed and now resolves uploads and downloads directly through promises, so the previous callback-based implementation no longer matched the actual runtime behavior.
  • The previous flow tied cleanup logic to callback completion paths, which made stream and listener handling more fragile after the SDK migration.
  • Using async/await with explicit abort propagation makes the code easier to read, easier to reason about, and safer to maintain.
  • Cancelling transfers on timeout or abort prevents leaving streams, listeners, or background operations alive after the caller has already considered the operation failed.
  • Removing unnecessary local multipart handling and compatibility wrappers keeps the integration closer to the SDK contract and reduces maintenance overhead.

@egalvis27 egalvis27 changed the title fix: downgrade @internxt/inxt-js version to 2.2.13 fix: Intall latest version 3.3.1 and fix braking changes Jun 16, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
40.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@egalvis27
egalvis27 merged commit bed67a2 into main Jun 17, 2026
10 of 12 checks passed
@egalvis27
egalvis27 deleted the fix/inxt-js-version branch June 17, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants